Jesper Christiansen

Results 15 comments of Jesper Christiansen

How would you change this, if in the future you wanted to add something like "Mark as spam" or similar bulk actions?

Also, I think I would have appreciated a comment on whatever was faulty in my approach on my PR - or a "mind if I take this over?" instead of...

I like your approach better. If the view comes with the bulk actions per default, I'd say you need to have the route addition in the install generator as well...

This is what I have in 1Password ![image](https://user-images.githubusercontent.com/311936/178744399-1a3c6f2b-0446-4254-b7a2-7520c6d15a1d.jpeg)

Adding www in front of railsdevs.com in 1Password doesn't make a difference either - just tried to see if that was it

Yep. Works fine for me with iCloud passwords as well - I missed that earlier, my bad. It was early :D

I think `subtype` is used as the "subtype" for the account. So for accounts where type is "credit", subtype can be any of: Mastercard, Visa, American Express, Discover - that's...

I like the way you've abstracted the types to the model - I think I'm going to do that in my PR as well!

@Shpigford is this what you had in mind?