epftoolbox icon indicating copy to clipboard operation
epftoolbox copied to clipboard

LEAR bug: exogeneous used at D-2, should be D-7

Open MichalJarema opened this issue 3 years ago • 2 comments

In file _lear.py, line 240, function build_and_split_XY():

There is for past_day in [1,2]:

Should be: for past_day in [1,7]:

MichalJarema avatar Sep 30 '22 11:09 MichalJarema

@gmarcjasz What do you think of this?

jeslago avatar Oct 09 '22 21:10 jeslago

It should be [1, 7] as Michal suggests - I tested both versions and the difference (depending on the dataset) of MAE and RMSE metrics is between 0 and 1% - but in all cases the corrected version is not worse. The code will be updated to reflect that change.

gmarcjasz avatar Dec 05 '22 11:12 gmarcjasz