SimpleScene icon indicating copy to clipboard operation
SimpleScene copied to clipboard

ssBVH code does not agree with comment

Open ylkurs opened this issue 3 years ago • 1 comments

The first if statement in the following code snippet (in file ssBVH_Node.cs)

           // perform the best rotation...            
            if (bestRot.rot != Rot.NONE) {
                // if the best rotation is no-rotation... we check our parents anyhow..                
                if (parent != null) { 
                    // but only do it some random percentage of the time.
                    if ((DateTime.Now.Ticks % 100) < 2) {
                        bvh.refitNodes.Add(parent); 
                    }
                }                
            } else {
                // ...
            } 

should be replace by the following line of code???

if (bestRot.rot == Rot.NONE) {

ylkurs avatar Oct 12 '22 14:10 ylkurs

That's very peculiar... as it would seem like this bug would cause it to hardly ever perform a rotation. I'm going to have to look more carefully at the code, but that if-condition does seem most likely wrong.

jeske avatar Oct 12 '22 16:10 jeske