flood icon indicating copy to clipboard operation
flood copied to clipboard

Dark mode fixes

Open FinalDoom opened this issue 1 year ago • 3 comments

Make login, connection interrupted, and loading screens not blaringly white when dark mode is preferred/selected.

Description

  • Used modal colors from torrent location setting modal to add dark mode colors to Panel
  • Used similar colors to change backgrounds, text, etc. on relevant components.
  • Removed theme parameter from Panel as it was not used and unnecessarily specified light by default
  • Add inverse class where necessary to affect input coloring

Screenshots

Light Mode / Previous always

image image image

Dark Mode

image

Neat thing on this above one, there's actually blue sliders on the loading hamburger that you basically can't see in light mode because of the brightness blowout, but the lower contrast in dark makes them visible. (Fun human vision stuff)

image image

Types of changes

  • [ ] Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • [ ] New feature (non-breaking change which adds functionality - semver MINOR)
  • [X] Bug fix (non-breaking change which fixes an issue - semver PATCH)

FinalDoom avatar Jan 02 '24 07:01 FinalDoom

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (748195a) 73.14% compared to head (92126e4) 73.14%.

:exclamation: Current head 92126e4 differs from pull request most recent head 470aca6. Consider uploading reports for the commit 470aca6 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #714   +/-   ##
=======================================
  Coverage   73.14%   73.14%           
=======================================
  Files          62       62           
  Lines       11375    11375           
  Branches      962      958    -4     
=======================================
  Hits         8320     8320           
  Misses       3041     3041           
  Partials       14       14           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 02 '24 07:01 codecov[bot]

can you paste some screenshots about this fix?

trim21 avatar Jan 07 '24 17:01 trim21

can you paste some screenshots about this fix?

Updated

FinalDoom avatar Jan 08 '24 15:01 FinalDoom