flood icon indicating copy to clipboard operation
flood copied to clipboard

Select All (ctrl+a) shortcut with modal open shouldn't modify selected torrents

Open FinalDoom opened this issue 4 years ago • 0 comments

  • Version used: Docker Latest as of post date
  • Environment name and version:
    • Web browser name and version Firefox
  • Operating system and version: Windows 10
  • Torrent client and version: Transmission

Summary

Select all shortcut Ctrl+A should not select all when a modal (set tags, set location, info, etc) is up.

Expected Behavior

Pressing Ctrl+A when a modal up and no text box selected is either discarded or passed to browser (Select all text on page) without modifying application state.

Current Behavior

Ctrl+A in a textbox selects text as expected. Ctrl+A without a cursor in a textbox selects all torrents in the list, altering the target of the modal operation (prone to catastrophic errors)

Possible Solution

As hinted, Pass through the ctrl+a event when a modal is up--I believe this should allow text boxes to continue to function correctly too.

Steps to Reproduce

  1. Select one or more torrents
  2. Right click and open Set Torrent Location or other modal popup option
  3. Click in text box, observe ctrl+a selects text
  4. Click on modal outside of textbox, observe ctrl+a selects all torrents (not maintaining selection that modal was opened with)

FinalDoom avatar Sep 27 '21 02:09 FinalDoom