2 Minor bugs that I found using flood with transmission

[J0shua-code]

Type: Bug Report

Your Environment

• Version used: 4.6.1
• Environment name and version:
  • Node.js version : v16.4.1
  • npm version : 7.18.1
  • Web browser : chrome
• Operating system and version: linux
• Torrent client and version: transmission 3.00 (bb6b5a062e)

Summary

Bug 1: Setting download priority does not update the UI realtime you have to reopen the file tab to see if the file download priority is updated

Bug 2: If we choose to download only partial torrent the progressbar and filesize does not adjust and display size accordingly

Expected Behavior

1. UI should update in realtime like the transmission web-ui

2. Progress bar should adjust accordingly

Flood:

Transmission web-ui:

[jesec]

1 is caused by a lack of polling of torrent contents. I will take a look.

2 is not necessarily a bug. Flood tries to unify the experience across different clients. Currently Flood uses the "absolute" percentage (completed/total size) instead of the one that may be scaled due to the "do not download" contents. I will see if it is better to follow the behavior of individual clients.

[FinalDoom]

A corollary to 1: When setting priority, changing what's selected (both additional and completely different files), the priority dropdown state isn't reset, so clicking the same state again does nothing.

Eg. Mark 1 "Don't download" then mark 2+3 "Don't download" looks like this:

• Check 1
• Click Don't Download
• Uncheck 1
• Check 2 and 3
• Look at dropdown and "Don't Download" is already checked. Clicking it does not change the state of 2 and 3. Expected is either it does something, or ideally it doesn't show Don't Download as checked since the selected files have changed. Probably would take extra logic to say "Do all the files have the same state, show that as checked" but would be ideal.

I may take a look at fixing this next time I feel like coding stuff.

For bug 2, I agree it's weird to have partial download bars for "complete" partial torrents, but it makes sense if different clients handle it differently. The data available at least from transmission is kinda weird too, with size, total size, available, wanted, complete percentage, and available percentage, or something like that.