Jesse Chan

Results 97 comments of Jesse Chan

No. Still long way to go at this point. We might have to use `vm.Module` which is in experimental status as of Node 18.2. I am generally against relying on...

Hmmm... We definitely don't want to have more env variables. Additionally, any Babel plugins have to be in the dependency (node_modules) tree of `pkg`. It is improbable to add them...

> @jesec In my case I needed to add `'classPrivateMethods'` and it doesn't require a plugin to be installed. It is used by a module of my application. Should I...

> > It might make some sense to shift the burden of the correctness check to users > > yeah like I said before, If someone really want to do...

> > we can use preset/env with targets.node set to the latest Node supported by us. > > How can we do this so? Basically, we allow using any language...

> You mean #1648 ? Yes. Per https://babeljs.io/docs/en/babel-parser#latest-ecmascript-features, we don't need to specify our own plugin array. The reliance on `estree` in our code is definitely an issue, and I...

Noted, but can't be implemented before the next major release.

#1400 Make sure that you are using the latest pkg.

See https://github.com/vercel/pkg#targets.

> @kldzj no clue, I'm sorry. @jesec ? I think there is something wrong with the virtual environment of GitHub Actions. Meanwhile, I still don't like the idea. However, I...