Jerry Jones
Jerry Jones
Thank you for the workaround ideas, @diegohaz! Those are super helpful.
Would the `accessibleWhenDisabled` prop on `` be useful here?
I did end up using accessibleWhenDisabled in the comment you linked to and it seems to be working. I haven't looked into this issue, but hopefully it helps!
Thanks @MaggieCabrera! I went ahead and removed the label because it is a larger change the bug it fixes is minor.
@youknowriad Sure! Thanks for flagging it.
@youknowriad I'm looking at https://www.codevitals.run/project/gutenberg and I see the increased Block Select time, but I'm having a hard time tracking down what this metric is really measuring. I've been looking...
@youknowriad @ellatrix The performance regression is because in order to know if the block toolbar will render or not, we need to rely on the [`useHasAnyBlockControls`](https://github.com/WordPress/gutenberg/blob/trunk/packages/block-editor/src/components/block-controls/use-has-block-controls.js#L12) hook, which loops through...
@ellatrix There are a few very specific instances: - [The navigation block in isolated editor](https://github.com/WordPress/gutenberg/pull/53110): You can get to a point where you have a block selected but no block...
The featured image replace one specifically is when the editor is in contentOnly mode, and the toolbar mostly only renders things in default editor mode. I'm not saying this is...
@youknowriad - I'm feeling stuck on how to address `useHasAnyBlockControls`. I spent a bit of time poking at different ways to improve the performance, and `useHasAnyBlockControls` was the main culprit....