LevelDB.jl icon indicating copy to clipboard operation
LevelDB.jl copied to clipboard

Published 20 hours ago • verified publisher icon jerryzhenleicai

Use of LevelDB_jll, documentation and github workflows

Open sadit opened this issue 1 year ago • 7 comments

This pull request contains integration with GH actions, documentation and LevelDB_jll (BinaryBuilder) as a way to make broader and simpler to mantain

sadit avatar May 27 '23 00:05 sadit

Dear @jerryzhenleicai

In addition to the previous changes, I also added support for other kinds of key-value types and iterators. These features changed the API and broke compatibility, so they increased the version number.

Please consider this pull request proposal.

Best, Eric

sadit avatar Jun 06 '23 16:06 sadit

Can we please get this PR merged?

asbisen avatar Sep 25 '23 17:09 asbisen

Sorry for the proscratination , I will try to review in the next few days.

jerryzhenleicai avatar Sep 25 '23 17:09 jerryzhenleicai

What does the Github Actions do? I am a bit unsure we want to introduce GitHub proprietary logic into this source package.

jerryzhenleicai avatar Sep 25 '23 18:09 jerryzhenleicai

Hi, GitHub Actions automatizes tests in this package. The idea is that after any push or pull request, a GHA container is run and verifies that tests are still passing. Such that the contribution, owner, and other people know if the commit is working, at least under the recorded tests

sadit avatar Sep 26 '23 18:09 sadit

Hi Jerry, Can we please merge this PR if there are no objections?

asbisen avatar Dec 10 '23 22:12 asbisen

I am happy with my private fork, but LevelDB is quite helpful and can positively impact people looking to create systems with the Julia language, mostly where LMDB is not the best option.

We can fork this repo + the commit and re-register the package under another name - something like LevelDB2. We can also think of joining it to some organization to simplify its maintaining

sadit avatar Dec 14 '23 19:12 sadit