pytest-split icon indicating copy to clipboard operation
pytest-split copied to clipboard

Add a comment to .test_durations explaining where the file came from

Open underyx opened this issue 3 years ago • 1 comments

Description

Heya! I had this feature request, and figured it's easiest if I create a PR rather than an issue. Let me know if you think it's a good idea; if so I'm happy to put more effort into the PR!

Checklist

  • [x] Tests covering the new functionality have been added
  • [ ] Documentation has been updated OR the changes are too minor to be documented
  • [] The Changes are listed in the CHANGELOG.md OR the changes are insignificant

underyx avatar Jun 28 '22 18:06 underyx

I like the idea of having a "comment" but I think it should not live in the same level as the data for the tests. I guess the initial choice regarding data structure was poor considering extensibility. E.g. something like

{
"test_duration_data": {"test_1": 0.1234, ...}
}

would have been more flexible.

jerry-git avatar Aug 02 '22 10:08 jerry-git