Jérôme Van Der Linden
Jérôme Van Der Linden
there's still requested changes, but I see nothing to change in the discussion...
Thanks @maschnetwork for the feedback, it's great to have another vision of the problem, and to actually put things in perspective (for example the fact we don't need to implement...
I tried to autowire the context but looks like the bean doesn't exist: ``` Field context in helloworld.HelloWorld required a bean of type 'com.amazonaws.services.lambda.runtime.Context' that could not be found. The...
https://github.com/aws-samples/serverless-patterns/blob/d287c7b58d96ddc5525cd995ce336ef0ee0287f6/s3-eventbridge-fargate-cdk/pattern.json
There's a [great comment](https://github.com/aws-powertools/powertools-lambda-java/pull/1620#issuecomment-2083456666) from @humanzz that outlines some of the issues that happen with thread pooling in general in a Java-Lambda environment.
Note that we can also handle the [APIGatewayV2HTTPEvent](https://github.com/aws/aws-lambda-java-libs/blob/main/aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/APIGatewayV2HTTPEvent.java) in the same way.
jax-rs => jakarta-rs, see https://jakarta.ee/specifications/restful-ws/3.1/jakarta-restful-ws-spec-3.1.html But as we need to be compliant with Java 1.8, we must stay on jax-rs imports and cannot use later version than 2.1.6.
⚠️ JAX-RS is based on reflection, which is slow. As it is intended to be used with API Gateway and supposed to be fast (sync call), it's an important drawback....
> I think the spotbugs warning needs an ignore in the overrides file: > > ``` > [ERROR] Medium: Public static software.amazon.lambda.powertools.metrics.MetricsUtils.metricsLogger() may expose internal representation by returning MetricsUtils.metricsLogger [software.amazon.lambda.powertools.metrics.MetricsUtils]...
Thanks @RMSD for reporting this issue. That's not an easy change as the service is added as a custom key (see [here](https://github.com/aws-powertools/powertools-lambda-java/blob/e7933c23bc33767d6e8887e8e0d5c36a5d0f7a36/powertools-logging/src/main/java/software/amazon/lambda/powertools/logging/internal/LambdaLoggingAspect.java#L123)) and used both in json layout and ecs...