Jerome Simeon

Results 307 comments of Jerome Simeon

A way around testing for the time being is included in PR accordproject/concerto-ui#27

> We should be careful to only add other dependencies where necessary as they bloat the bundle in downstream apps. > > Providing a robust implementation only for this one...

> Update on this: https://momentjs.com/docs/#/-project-status/ > > Maybe use https://moment.github.io/luxon/ Resolution on this, if any, should be consistent with whatever we decide on Concerto itself. See https://github.com/accordproject/concerto/issues/205

> > @DianaLease would you have cycles to pick this one up, now that we have updated Concerto? > > Sure thing! To make sure I understand the issue -...

> @dselman @jeromesimeon Looking into this more, I'm not sure it's actually necessary to introduce dayjs the way the current `concerto-ui` code is implemented (a bit has changed since this...

This is design mode. I think we still want to do this?

**Model** ``` asset CopyrightLicenseContract extends AccordContract { /* the effective date */ o DateTime effectiveDate /* licensee */ o AccordParty licensee o String licenseeState o String licenseeEntityType o String licenseeAddress...

We may need to revisit the question of fully qualified names... Template mark holds on to the `licensee` and `licensor` variables, but those are expanded (since they are complex types)...

> I see - so we need to distinguish between the name of the field to be updated when editing, and the name of the variable in the model (field...