Jerome Gravel-Niquet

IIRC it’s either a rails thing or slim thing in production where it compresses the HTML as much as possible. Could be a setting with the parser. On November 24,...

I agree. I've had this problem before with inline elements with slim. I'm wondering what's the best way to do this. Basically trim all whitespace everywhere between "nodes" (text and...

Chiming in here: I don't think this is a _huge_ change. I've been out of touch with Crystal, so I'd rather somebody else contribute a PR :) I do think...

Looks great to me!

This is what I get when I run it with VERBOSE=1 ``` Runner command: /Users/jerome/projects/github.com/superfly/v8-cr/lib/bindgen/src/bindgen/parser/../../../clang/bindgen /var/folders/wd/y9m3t11s6nx1nhyzqmhnxmr40000gn/T/bindgen.tfMeLu -m "" -f "" -- -x c++ -std=c++11 -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS In file included from...

As for the spec, I got this: ``` $ crystal spec .................................................................................................................................................................................................................................................................................................................................In file included from /var/folders/wd/y9m3t11s6nx1nhyzqmhnxmr40000gn/T/bindgen.FBLx6t:1: /Users/jerome/projects/github.com/superfly/v8-cr/lib/bindgen/spec/integration/arguments.cpp:1:10: fatal error: 'string' file not found #include ^~~~~~~~ arguments.cpp:22:32: error: no viable conversion...

Ok, adding the resource-dir option fixed it, but the JSON is full of empty objects: ``` $ ./lib/bindgen/clang/bindgen /usr/local/include/v8.h -m "" -f "" -- -x c++ -std=c++11 -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -resource-dir...

Oh nice, adding one class produced a big JSON output. I had to change the runner.cr to pass this argument I need to make it work with the usage from...

Thanks, that helps! Looks like it's working well. The TEMPLATE has great comments, but I didn't know what I didn't know before, meaning I didn't know what to make of...

Yes, I think a converter would do the trick. I think there are issues with the v8 namespacing. If I don't manually write those `types` in addition to the `classes`,...