Laravel-Prerender icon indicating copy to clipboard operation
Laravel-Prerender copied to clipboard

Published 20 hours ago • verified publisher icon jeroennoten

Laravel 6 support

Open oixan opened this issue 5 years ago • 6 comments

Any chance that this package can be updated for Laravel 6?

oixan avatar Sep 21 '19 11:09 oixan

Not sure if this package is still being maintained? @jeroennoten could you shed some light on this? Thanks very much!

denjaland avatar Sep 26 '19 17:09 denjaland

Hi, unfortunately I don’t have the time to maintain this package.

jeroennoten avatar Sep 27 '19 11:09 jeroennoten

Sad news, I hope someone can work on this package in the future!

Just 1 thing. Changing on composer.json file "illuminate/support": "~5.0.14|~5.1", to
"illuminate/support": "~5.0.14|~5.1|^6.0" will make the package work with laravel 6?

oixan avatar Sep 27 '19 18:09 oixan

I took a copy of the middleware and put in our codebase directly. You can change compoer dependency, and there is one array_ or str_ function ( don’t recall by heart) that needs updating...

denjaland avatar Sep 27 '19 18:09 denjaland

PrerenderMiddleware.php has 2 str_ functions. Line 154 change str_contains to Str::contains and line 248 change str_is to Str::is.

keliix06 avatar Nov 06 '19 14:11 keliix06

I researched the forks a bit, I think these two are complete:

  • https://github.com/ahtinurme/Laravel-Prerender
  • https://github.com/keliix06/Laravel-Prerender

I chose the latter, but forked it so I can tag it with a release.

bilias23 avatar Nov 10 '19 10:11 bilias23