RevitLookup
RevitLookup copied to clipboard
jeremytammik
Geometry visualization
Summary of the Pull Request
What is this about:
Geometry visualization engine. Is under development
Description:
Completed:
-
Mesh
-
Face
-
XYZ (disabled for normal vectors)
TODO:
- Solid
- Bounding box
- Edge
Quality Checklist
- [x] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
Qodana for .NET
22 new problems were found
| Inspection name | Severity | Problems |
|---|---|---|
Invert 'if' statement to reduce nesting |
◽️ Notice | 6 |
Convert 'if' statement into 'switch' |
◽️ Notice | 5 |
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used |
◽️ Notice | 4 |
Member can be made static (shared) (private accessibility) |
◽️ Notice | 4 |
'if-return' statement can be rewritten as 'return' statement |
◽️ Notice | 2 |
Convert local variable or field into constant (private accessibility) |
◽️ Notice | 1 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report
Detected 200 dependencies
Third-party software list
This page lists the third-party software dependencies used in RevitLookup
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
by the way, for 2D geometry like room boundaries etc., are you aware of my GeoSnoop utility? https://thebuildingcoder.typepad.com/blog/2014/04/determining-the-size-and-location-of-viewports-on-a-sheet.html
@jeremytammik thanks Jeremy for sharing the link, yes I have heard of it and seen it in some articles. In the current implementation I am using DirectContext3D to render 3d geometry, this will give a lot of possibilities to create independent geometry with many customisations
The geometry rendering looks finished. It remains to write documentation and brush up all little details. Release is planned for next week
If you have any suggestions or comments on what you see in the screenshots in the PR, write it here
In the XYZ visualisation, is there a way to distinguish between X, Y and Z axes?
is thjere a way to control the length of the little vectors showing mesh triangle orientation? in the mesh, can one see the orientation of each triangle, i.e., the order of its three vertices (clockwise, anticlockwise)?
this is brilliant work. it wil have a very significant positive impact on the usefulness of RevitLookup! thank you!
In the XYZ visualisation, is there a way to distinguish between X, Y and Z axes?
The only difference now is that they always point in the directions XYZ.BasisX, XYZ.BasisY, XYZ.BasisZ. DirectContext3D doesn't allow us to add text, any other ideas how we can highlight them?
is thjere a way to control the length of the little vectors showing mesh triangle orientation? in the mesh, can one see the orientation of each triangle, i.e., the order of its three vertices (clockwise, anticlockwise)?
Interesting, might think about it, do you suppose it would be useful?
any other ideas how we can highlight them?
some coordinate system visualisations use three colours, e.g., RGB.
do you suppose it would be useful?
only as little. when there are very many close together and they overlap a lot. low priority, though, IMHO.
Great suggestion about the colour. Clockwise, anticlockwise direction we can just finalise in the next releases
Added documentation, Wiki section will be updated after release.
@jeremytammik If you notice typos, please write if you have time of course
I belive that visulize by RGB is good idea, I did similar idea to visulize coordinate system before by color 👍
the description and images in your comment look good and clear, clearly explaining the purpose and us. i edited the first sentence, adding analysis and understanding of the BIM, and added 'aligned to cardinal axes' for bounding boxes. in XYZ visualization, i wonder whether one should add a note of Transform and or coordinate system. would they apply to the XYZ visualisation as well?
exactly, it is necessary to specify that we apply Transform to all BoundingBoxes. About XYZ, they are displayed as they are, according to their value. but visualisation of normal points with length 1 is disabled
blog post is now live: https://thebuildingcoder.typepad.com/blog/2024/06/revitlookup-geometry-visualisation.html