Jeremy Wootten

Results 1759 comments of Jeremy Wootten

I suggest you install `io.elementary.vala-lint` from `https://github.com/vala-lang/vala-lint.git` so you can de-lint the code locally. There are a few warnings atm: ``` ../src/View/ColumnView.vala 96.14 error Expected space before paren space-before-paren 96.30...

@shiruken I had quite a lot of comments on the code, mostly stylistic. I pushed a PR to your branch as it was easier than having a lot of comments....

@shiruken1 You did remarkably well for your first attempt with Vala/elementaryos!

Buttons are usually aligned at start or end when on the last line of a dialog but @danirabbit has final say on design.

> Should I start working on something for the other views I should wait to see what reception this PR gets. Hopefully much of what you have done here can...

@shiruken1 I would envisage another switch in the settings menu in the headerbar under "Show in View". I'll see if I can implement if you like. Looks like this is...

You also need to listen for changes to the setting and update the ColumnView accordingly, adding or removing the details pane as appropriate.

Don't forget to de-lint: ``` jeremy@OS8-VM-2:~/Elementary/files/build$ lint ../src/View/AbstractDirectoryView.vala 1451.64 error Expected space before paren space-before-paren ../src/View/Window.vala 1102.47 error Expected a single space double-spaces ../src/View/Miller.vala 132.64 error Expected space before paren...

> Yea. I get this despite all I've written 😩 You need to actually install the branch because you have changed the schema. Even when running in `./build` it will...

@shiruken1 You should not need to do anything in particular - just run `sudo ninja install`. Make sure that that there aren't any old Files processes running though using System...