Jeremy Wootten
Jeremy Wootten
@danirabbit I have a problem with styling the theme buttons in the SettingsPopover. It looks like valid CSS is being loaded into the css_provider but it has no effect. Maybe...
@danirabbit Thanks for the review! I'll double-check whether there is anything that is not essential to change and address the other issues. It hard not to try and make "improvements"...
> You've introduced a lot of `todo` and `fixme` and `note` comments here that are just things like "Make sure this works in GTK4". So I think those all need...
@danirabbit Sure, if its OK to omit failing (headless) tests for the first Gtk4 merge. Considering most elementary projects do not have any unit tests I should think this wouldn't...
@danirabbit Not sure I can properly test `match_keycode` with non-standard hardware as I do not have any. Need to get a suitable reviewer to test it really. Other than that...
Checked that the copy/paste shortcuts still work when a non-English keyboard layout is selected.
@danirabbit I think this is pretty much ready to merge subject to your approval. I don't think the issue with headless testing in Gtk4 should necessarily hold up going ahead...
@danirabbit Oh OK, sorry I didn't realize. No hurry - please take all the time you need to recover.
@lenemter Thanks for taking a look at this! > Looks like color dialog styles got broken a bit: Could you point out the main differences? I must be a bit...
Ah, the leading margin is a little larger in Gtk4. And the trailing margin and margin between grid and button.