Jeremy L Thompson

Results 251 comments of Jeremy L Thompson

Correct me if I'm wrong, but I understand from the comments and commits that the core tests, t1*-t5* and ex1, ex2 all pass with these changes. In preparation for our...

Thanks for all the hard work here @kris-rowe! PETSc released last week, so I'd like to tidy up the big open PRs and get a libCEED release soon. I don't...

Ok, https://github.com/CEED/libCEED/pull/1072 should be ready to merge now

This PR is not associated with an issue that was filed. Can you explain why these changes are needed?

Sure. We don't assign issues - we accept the first complete PR that addresses the issue. In ttis case, we are looking for someone to update the description of the...

There is a very large possible number of solutions. I do not think it is a good idea trying to write every single possible solution out.

Or we could skip all that and make a simple, lightweight expression parser.

Not really though, since we only have four operations. I'm making up a smaller parser right now

This isn't fully bulletproof, but this is the basic idea: ```javascript const OPERATORS = { "+": (a, b) => a + b, "-": (a, b) => a - b, "*":...

`3 indents` is not a meaningful phrase for learners - we have not included anywhere in this step what `an indent` as a noun means and there are many conventions...