Jeremy Lenz
Jeremy Lenz
[test Redmine issues]
> wouldn't a third option be to pass `**{}` as a second argument to `report_row` to force ruby to treat the merged hashes as a positional argument? Can confirm that...
One possibility I was thinking about was that in addition to _calling_ `report_row` with kwargs, we also make it require them. Currently the definition is just ```rb def report_row(args) ```...
> setting the target version in Redmine to 3.10? done
> we could bump here safemode to `< 1.4.0` until we drop Ruby 2.7 support, in that case we won't need to change anything in templates and won't break any....
@ekohl I don't understand what changes you are requesting? Should I change it back to what it was before?
> If (and that's a big if) you're pinning to an older version you must revert [93ac254](https://github.com/theforeman/foreman/commit/93ac254d954c46924a78860f86678ff81139fe89) Oh yes, I have no desire to revert that. I'll change it back.
Reverted back to passing kwargs.
Made the change suggested by @ofedoren. @ekohl I'll squash if you're good with this approach.