Jeremy Friesen

Results 66 comments of Jeremy Friesen

@michael-tharrington Could you paste an example of what you mean by quotation?

Reading Notes: I did some investigation, and I believe that we're encountering unescaped characters in JS data. I believe we'll need to change the following: https://github.com/forem/forem/blob/5579f3360c02a0adddeeeee22e89fcfb5e70df87/app/javascript/responseTemplates/responseTemplates.js#L40 and https://github.com/forem/forem/blob/5579f3360c02a0adddeeeee22e89fcfb5e70df87/app/javascript/responseTemplates/responseTemplates.js#L58

Reading notes: I think a helper function akin to what was added in #16067 would make sense.

@fbanning Thank you for submitting the bug report. I'm notifying @amywtlin to triage this relative to other priorities.

This relates to #18111 > Reading Note: In past conversations with former team members they mentioned that our current markdown parser needs revisiting. The challenge in this revisitation is that...

@KirtanSoni Sorry about the delay in getting to this, but I've assigned this to both you and me so we can both track it.

This relates to #18111 > Reading Note: In past conversations with former team members they mentioned that our current markdown parser needs revisiting. The challenge in this revisitation is that...

To "fix" this may require significant work (e.g. upgrading the underlying parser, which might involve looking for a new parser). This is why I prefixes my comment with "Reading Note",...

@aitchiss Typically in a paginated response document we have a response document that includes: - `next_page` - `previous_page` - `total_pages` - `entries` Were I thinking of an implementation, I'd perhaps...

Oooh, if most are `{ results: { entries as json } }` then this will be a lot easier to proceed.