dynamodb-toolbox icon indicating copy to clipboard operation
dynamodb-toolbox copied to clipboard

Update method types overlay 2

Open Sevi7 opened this issue 2 years ago • 1 comments

Thanks for the quick release of the previous fix! However, the update method types overlay is still not working for me, I found another possible issue:

The return type of update method contains FirstDefined<[O.Pick<Item, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]> and the response type I get for Attributes is {} | undefined.

I think it should be FirstDefined<[O.Pick<EntityItemOverlay, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]>. What's more, the response I get is FirstDefined<[O.Pick<EntityItemOverlay, ResponseAttributes>, EntityItemOverlay, MethodItemOverlay]> | {} | undefined. I think there is something more to resolve in order to get rid of that {}

Sevi7 avatar Nov 14 '22 13:11 Sevi7

Hey, can you send your entity config + an example of specific response you would want to see based on that config?

Thanks!

naorpeled avatar Nov 14 '22 14:11 naorpeled