automatic-theme-plugin-update icon indicating copy to clipboard operation
automatic-theme-plugin-update copied to clipboard

Solving WordPress server error message in Add New theme screen

Open javistuff opened this issue 10 years ago • 1 comments

Hi there!

A quick heads up for something that was troubling our setup.

On the Add new theme screen, we were getting this error:

"An unexpected error occurred. Something may be wrong with WordPress.org or this server’s configuration. If you continue to have problems, please try the support forums."

Seems like interfering the themes_api in this screen won't behave nicely. Mostly because not all arguments are present in the request. We've fixed it by adding this:

if ( !property_exists($args, 'slug') ) return false;

right before this line:

if ( $args->slug != $theme_base ) return false;

Just wanted to share it here, in case someone needs that too. Thanks for this great library!

javistuff avatar Nov 24 '14 14:11 javistuff

Hi,

I don't understand how themes_api filter works? Is it working only in add new theme screen?

In this page (https://github.com/jeremyclark13/automatic-theme-plugin-update/blob/master/theme/update.php) said "Take over the Theme info screen on WP multisite". But the theme info screen (like plugin screen modal dialog - as I understand) is just iframe and already got it via theme_update action.

And the add new theme screen don't have my custom theme in there because all of theme list here is on WordPress.org only.

ve3 avatar Nov 21 '16 01:11 ve3