automatic-theme-plugin-update icon indicating copy to clipboard operation
automatic-theme-plugin-update copied to clipboard

Some issues, and ideas

Open oferwald opened this issue 11 years ago • 7 comments

bad use of slugs

the code uses the directory and then assumes that the plugin is in the format of slug/slug.php which is not always correct, sometimes the php file has a different name

missing upgrade_notice

Sending this can give a nice effect, and it just needs to be added to packages.php

a suggestion, stop querying wordpress.org when using internal updates.

Why inform and query wordpress.org on irrelevant stuff? see this code example: (for example, to hide bbpress)


function filter_parse_arr($arr, $url) {
    // hide from wordpress.org
    if ($url == "http://api.wordpress.org/plugins/update-check/1.0/") {
        $plugs = unserialize($arr['body']['plugins']);
        unset($plugs->plugins['bbpress/bbpress.php']);
        $arr['body']['plugins'] = serialize($plugs);
    }
    return $arr;
}```
### another suggestion, add a counter to the download.php

I implemented this locally with mysql, many other ideas can work

Great work, all in all :)

oferwald avatar May 05 '13 14:05 oferwald

Agreed about the slug, I've got to dig into how WordPress generates the slug. I've had numerous occasions where the slug being different than expected caused problems.

That's very interesting about blocking the the plugin from sending info over to WP.org as well.

Yeah when the original script relied on a mysql database for securing the downloads I had thought about this as well. I currently mulling over moving this into a WordPress plugin to add some more advanced features. Just need the time.

Thanks again for the report and ideas.

jeremyclark13 avatar May 05 '13 14:05 jeremyclark13

to get the slug use plugin_basename( __FILE__ ). however this script need complete rewrite. in a way I'm not recommending to use this script. there's a lot that need to be fixed.

i just release http://autohosted.com plugin to manage auto update. it's a commercial plugin, but all documentation is open to read.

turtlepod avatar May 05 '13 15:05 turtlepod

Just looked into plugin_basename, and when I was about to post, your message popped up.

Good luck with the new plugin, why don't you make it into an optional service?

oferwald avatar May 05 '13 15:05 oferwald

@oferwald thanks. about service: no plan for that.

you need to read this docs if you want proper sanitation for plugin sections: http://autohosted.com/docs/plugin-sections-allowed-tags/

turtlepod avatar May 05 '13 15:05 turtlepod

Looks like @turtlepod beat me to the plugin, good luck with that. I just haven't had time lately to work on this much, but I do plan on working on it again and hopefully fixing the problems that there might be. Like @turtlepod said a complete rewrite is in order and as of right now I just don't have the extra time. Hopefully soon though.

jeremyclark13 avatar May 05 '13 15:05 jeremyclark13

@oferwald Hey! Could you elaborate on the upgrade_notice element? Where does that appear? I'm presuming that's what creates the highlighted band under a plugin with an update available? I'd like to be able to employ this as well.

holisticnetworking avatar Feb 03 '14 20:02 holisticnetworking

@holisticnetworking just add this to the packages array (if I remember correctly).

oferwald avatar Feb 04 '14 08:02 oferwald