react-native-modalize icon indicating copy to clipboard operation
react-native-modalize copied to clipboard

Iphone 14 modalTopOffset default is off

Open brianedelman opened this issue 2 years ago • 6 comments

Describe the bug On iphone 14 (specifically tested on Pro) with iso 16.0 the modalTopOffset needs to be adjusted in a way that it doesn't need to be for other iphone models.

The same implementation produces these results on 13 vs 14. I can manually add modalOffset top to resolve the issue but I believe this should be handled by default.

Reproduce Screen Shot 2022-09-14 at 12 33 12 PM

Dependencies:

  • react-native-modalize 2.1.0
  • react-native 0.65.1
  • react-native-gesture-handler 1.10.3

brianedelman avatar Sep 14 '22 16:09 brianedelman

Please, fix issue on iPhone 14 :(

LongVT8 avatar Nov 07 '22 02:11 LongVT8

I have this issue as well on my iPhone 14 Pro Device with iOS 16.1. Oddly my Simulator with the same setup renders it correctly.

harrigee avatar Nov 23 '22 08:11 harrigee

Same here. Both simulator and real device. Thought rn-device-info would fix it :/

kg-currenxie avatar Nov 24 '22 02:11 kg-currenxie

@harrigee @brianedelman @kg-currenxie @LongVT8 I pushed the corrected commit and deployed the update as an npm module after forking, just in case https://www.npmjs.com/package/react-native-patch-modalize

devym-37 avatar Mar 30 '23 06:03 devym-37

Any updates? I have this issue as well on iPhone 14 and now also iPhone 15.

akruczek avatar Oct 11 '23 12:10 akruczek

@akruczek I pushed the corrected commit and deployed the update as an npm module after forking, just in case https://www.npmjs.com/package/react-native-patch-modalize

devym-37 avatar Oct 11 '23 12:10 devym-37