Bitter icon indicating copy to clipboard operation
Bitter copied to clipboard

Add a method to return the count by period with interval

Open jeremyFreeAgent opened this issue 12 years ago • 5 comments

See #11 for the start of the talk.

jeremyFreeAgent avatar Dec 24 '12 10:12 jeremyFreeAgent

I'm +1 on @shouze comment:

bitDatePeriod needs to be renamed into bitDateRange as it looks confusing ATM A new method needs to be introduced, something like countByPeriodWithInterval(\DateTime $from, \DateTime $to, \DateInterval $interval). This method should return an array or any iterable object collection.

stephpy avatar Dec 24 '12 10:12 stephpy

On second point. Why does not use

countByPeriod(\DatePeriod $datePeriod) ?

stephpy avatar Dec 24 '12 10:12 stephpy

There is no more bitDatePeriod, it's bitDateRange now. :hammer:

jeremyFreeAgent avatar Dec 24 '12 10:12 jeremyFreeAgent

DatePeriod is a holy crap. I think it's a trainee who made it... :school_satchel:

jeremyFreeAgent avatar Dec 24 '12 10:12 jeremyFreeAgent

Yes, let's overwrite it :)

stephpy avatar Dec 24 '12 11:12 stephpy