Jeremy W. Murphy
Jeremy W. Murphy
So anyway if you don't want to run the benchmarks yourself, here are mine: ``` 2018-11-26 23:56:10 Running /var/tmp/graph/RelWithDebInfo/benchmark/tree_algorithms Run on (8 X 3700 MHz CPU s) CPU Caches: L1...
I don't get why this isomorphism test is failing on this branch: ``` gcc.compile.c++ ../../../bin.v2/libs/graph/test/isomorphism.test/gcc-7.3.0/debug/visibility-hidden/isomorphism.o In file included from isomorphism.cpp:24:0: isomorphism.cpp: In function ‘void test_isomorphism2()’: isomorphism.cpp:136:76: error: no matching function...
> I don't get why this isomorphism test is failing on this branch: Ah, I see, it's not me. This compilation error is fixed by #137 .
Hmmm, I can't get GCC 4.6 to install on my machine, so I'm going to have some trouble tracking down why it's not compiling for that version. Hmmm, unless, I...
Yup, still working on it, any help appreciated.
I'm planning to put some effort into this PR again, so I'll try to make some priorities: 1. Resolve conflicts with `develop`. 2. Change implementation to use `std::optional` instead of...
If there is no existing issue or pull request open for it then presumably no-one else is working on it. Sounds like a good contribution to Boost.Graph. You don't have...
I'm not familiar with this part of the codebase, but... if you make a pull request, I can help you get it merged in.
Thanks for taking the time to implement this. It looks good, but as I said earlier it will take a few rounds of feedback to get it to be consistent...
I marked this as a draft for now in the hope that it won't trigger the CI every time you push -- I'm still learning how this CI system works....