Jeremy W. Murphy

Results 147 comments of Jeremy W. Murphy

I just realized that the sparsification step is probabilistic, so unit tests will only be able to test that the result has certain properties, etc.

Ok, now things are coming back to me about testing algorithms that use randomization. Basically, the RNG will be a parameter to the algorithm for two reasons: i) these things...

You're absolutely right -- teamwork is the key. Don't go up the mountain for forty nights and come back with an algorithm on stone tablets. :) I recommend some amount...

Interesting. I would have to dig into the commit history to find out why.

Sorry, I haven't had a chance to work on it.

Thanks for contributing a fix. Could I ask you to please also add a small unit test that demonstrates the new functionality? (I.e. the test should fail without your changes.)...

> If necessary I could translate it to a minimal C++ code. Yes, please, that is what I would like. The `develop` branch appears to be green now, so we...

@count0 do you have time to address the issues I commented on and add the unit test?

Thanks for pointing it out. If you can open a pull request, that will help speed up fixing it.

Yes, the algorithm has `DFVisitor&` in the declaration, but if you search for all the references to "visitor" on that page, you'll notice that it is otherwise defined as being...