Jeremy Croff

Results 50 comments of Jeremy Croff

> Thanks for your proposal @ZhenjaHorbach @jeremy-croff, > > @ZhenjaHorbach Sorry but i dont think you solution is a reliable way, to detect the done button press and looks like...

@s77rt ## Proposal ### Please re-state the problem that we are trying to solve in this issue. After navigating back in the bank account setup, the changed fields are not...

> reimbursementAccountDraft I chose to merge them onto eachother so that on initial render, draft gets created from reimbursementAccount. Then any user entered details get merged on top of it...

> @jeremy-croff > > > This way draft is a complete object > > I don't see the need for this. The draft merge process does not require you to...

> @jeremy-croff That logic was introduced by #28305 to fix #25996. As long as the new approach still fixes the linked issue then we should be fine This is very...

## Proposal ### Please re-state the problem that we are trying to solve in this issue. draft changes not saved on back button flows that don't have a Save and...

> @jeremy-croff Thanks for the follow up. You and @abzokhattab have very similar solutions. I think its fair to go with @abzokhattab for having the first complete (working) proposal. My...

My original.proposal is currenly hidden because my github account is currently suspended while it's being recovered. The proposal should be in an email history. The proposal was to use the...

This is because of a regression from: https://github.com/Expensify/App/pull/33863 ## Proposal ### Please re-state the problem that we are trying to solve in this issue. Page loading screen icon color is...

> @jliexpensify Since [the fix PR](https://github.com/Expensify/App/pull/35097) for this GH issue is using [my proposal](https://github.com/Expensify/App/issues/35018#issuecomment-1907375427), can you assign me to this GH issue for compensation, thank you! Is this common practice?...