Jeremy Croff

Results 50 comments of Jeremy Croff

> > > Did you try using the scrollToEnd() method provided by the ScrollView component? That should solve this case if all you need to do is to just scroll...

@NikkiWines I'm reviewing the composer consistency idea and have the following considerations: We have specific code to not focus the composer on touch devices. The comments specify because it's jarring....

While developing I identified a one liner that caused this issue: updating ```export default setShouldShowComposeInputKeyboardAwareBuilder('keyboardWillHide'); ``` to ```export default setShouldShowComposeInputKeyboardAwareBuilder('keyboardDidHide');``` https://github.com/Expensify/App/blob/bfae5b2cb8aa0731dc49745be942cf985cdaf5bc/src/libs/setShouldShowComposeInputKeyboardAware/index.ios.ts#L5 Fixes this issue, and is the root cause. Only...

@allroundexperts I'm looking for approval on the information above. I have a draft PR open and can finalize the checklist if this looks good.

> That's fine @jeremy-croff. Please open the PR so I can test it. I have opened the draft for review so you can test it. I will be in office,...

> Ah great question @ZhenjaHorbach! > > We would like the 'Done' button on the keyboard to close the edited message and the keyboard should be dismissed. I'll add that...

## Proposal ### Problem The 'Done' button on the message editing page does not submit the edited message, and there is no action defined for it. ### Root Cause The...