org-msg icon indicating copy to clipboard operation
org-msg copied to clipboard

org-msg is not activated with mu4e-compose-reply

Open baracunatana opened this issue 2 years ago • 17 comments

Hi everyone.

I have the same issue as https://github.com/jeremy-compostella/org-msg/issues/87 after updating my pc (it was working fine two days agoTM). Composing a new email (with mu4e-compose-new) works as intended, but mu4e-compose-reply doesn't activate org-msg (however, org-msg-mode evaluates to t in the reply buffer). I can call org-msg-edit-mode and it kind of works (I can use org to edit my message), but it doesn't add my signature and the original message is displayed whit > and not with the outlook style.

I tried going to the previous commit or org-msg (https://github.com/jeremy-compostella/org-msg/commit/77f5911b7d390a069104db20be86293506ffbff2) but it didn't work.

I have mu4e 1.8.1, org-msg 4.0 and emacs 29.05. I also set mail-user-agent to 'mu4e-user-agent in my config file.

Any help is appreciated.

baracunatana avatar Jul 01 '22 13:07 baracunatana

I have the same issue, but with some differences:

  • If I load mu4e before org-mode, org-msg isn’t loaded at all and org-msg-mode evaluates to nil in the reply buffer
  • If I load org-mode, then org-msg is loaded correctly and works as expected

For the record, here are the relevant software versions:

  • mu & mu4e 1.8.1 (installed from the AUR on Arch Linux)
  • org-msg 4.0 (commit 60e22e4, master’s HEAD at the time of this message)
  • Emacs 29.0.50 (commit https://github.com/emacs-mirror/emacs/commit/1dc70544d8)

Here is my relevant org-msg configuration (stripped of a few lines, full version available here):

(use-package org-msg
  :after (org mu4e)
  :straight (:build t)
  :hook ((mu4e-compose-pre . org-msg-mode))
  :config
  (setq org-msg-default-alternatives '((new           . (text html))
                                       (reply-to-html . (text html))
                                       (reply-to-text . (text)))))

Phundrak avatar Jul 03 '22 10:07 Phundrak

@Phundrak Thanks for the help. I tried your customization for org-msg-default-alternatives and org-msg is now launched when replying to a message. However, it isn't converting the citation to outlook format (i.e. I still have the > citation style). Also, the signature is added after the citation. I have org-msg-convert-citation set to t, but still no luck. Do you have the same issue?

baracunatana avatar Jul 05 '22 02:07 baracunatana

@Phundrak Thanks for the help. I tried your customization for org-msg-default-alternatives and org-msg is now launched when replying to a message.

I still have the issue of org-msg not firing up if org-mode is not loaded on my side.

However, it isn't converting the citation to outlook format (i.e. I still have the > citation style). Also, the signature is added after the citation. I have org-msg-convert-citation set to t, but still no luck. Do you have the same issue?

I completely forgot I had org-msg-convert-citation set to t too, turns out it never worked, I always had the greater-than citation style. But I guess this is a separated issue from the current one.

-- Lucien “Phundrak” Cartier-Tilet https://phundrak.com (Français) https://phundrak.com/en (English) Sent from GNU/Emacs

Phundrak avatar Jul 05 '22 13:07 Phundrak

I can confirm that going back to mu4e 1.6.10 (from 1.8.1) solves the issue. It seems that recent changes in mu4e interfered with org-msg in some way.

baracunatana avatar Jul 05 '22 14:07 baracunatana

I still have the issue of org-msg not firing up if org-mode is not loaded on my side.

What if you configure it with only :after (mu4e)

baracunatana avatar Jul 05 '22 16:07 baracunatana

I still have the issue of org-msg not firing up if org-mode is not loaded on my side.

What if you configure it with only :after (mu4e)

It indeed works, thanks!

Previously, org loaded when mu4e loaded, supposedly because mu4e loaded org-msg at the same time, but now both org-msg and org load when I first enter edit an email (creating, replying to, or forwarding an email), which is actually an improvement in my opinion.

This issue is resolved on my side.

-- Lucien “Phundrak” Cartier-Tilet https://phundrak.com (Français) https://phundrak.com/en (English) Sent from GNU/Emacs

Phundrak avatar Jul 06 '22 09:07 Phundrak

I also started experiencing this issue after upgrading to the latest version of mu4e (1.8.5). @baracunatana, where you able to identify the cause of the problem, or are you still using an earlier version of mu4e?

benthamite avatar Jul 12 '22 02:07 benthamite

@benthamite My debugging skill are not up to this challenge, so I just went back to mu 1.6.10 and it works perfectlly now.

baracunatana avatar Jul 12 '22 12:07 baracunatana

Also having the same problem when composing replies with mu/mu4e 1.8.5. Will watch this issue to see if there's a resolution.

ifinkelstein avatar Jul 12 '22 13:07 ifinkelstein

I confirm that downgrading to 1.6.11 solved the issue for me. FYI, here's the mu 1.6.11 homebrew formula. To downgrade with brew, save the file, then

  1. $ brew uninstall mu
  2. $ brew install /path/to/mu.rb
  3. $ brew pin mu

benthamite avatar Jul 12 '22 14:07 benthamite

@Phundrak is this still working for you? I tried to apply your config, but I still get the ">" quotation. org syntax works, however.

bergheim avatar Sep 02 '22 10:09 bergheim

My guess: under mu 1.8.* I cannot retrieve the fields :body-txt or :body-html from message property list anymore. Expressions like (mu4e-message-field msg :body-html) (as in org-msg-article-htmlp-mu4e) evaluate to nil and org-msg selects the reply-to-text alternative in every case.

tizero avatar Sep 10 '22 13:09 tizero

My guess: under mu 1.8.* I cannot retrieve the fields :body-txt or :body-html from message property list anymore. Expressions like (mu4e-message-field msg :body-html) (as in org-msg-article-htmlp-mu4e) evaluate to nil and org-msg selects the reply-to-text alternative in every case.

I've the same issue. I check mu4e-message-field and it's return nil as you say.

cnoceda avatar Sep 21 '22 11:09 cnoceda

Could https://github.com/djcb/mu/issues/2337 be related?

david-alvarez-rosa avatar Sep 21 '22 12:09 david-alvarez-rosa

Org-msg works for me, and I removed `org-msg-convert-citation' my config so I cannot answer regarding this issue.

-- Lucien “Phundrak” Cartier-Tilet https://phundrak.com (Français) https://phundrak.com/en (English) Sent from GNU/Emacs

Phundrak avatar Oct 11 '22 07:10 Phundrak

I don't think so @david-alvarez-rosa - this has always been like this for me.

I still cannot get org-msg to work the way it did. Replies will be text only.

Also, as @Phundrak mentions as well, org-msg-convert-citation has never worked for me either.

If I force HTML, things still work fine, so I guess it is related to :body-html not being part of the message anymore. If I do this:

        org-msg-default-alternatives '((new               (html))
                                       (reply-to-html	. (html))
                                       (reply-to-text	. (html)))

I get the correct reply, but then everything will be an HTML reply.

bergheim avatar Oct 28 '22 15:10 bergheim

I've put in a PR that I think fixes the mu4e issues: https://github.com/jeremy-compostella/org-msg/pull/159

gajama avatar Dec 01 '22 18:12 gajama