adjust signature position for replies

[Perangelot]

This change inserts the signature not after all the citations, but after the actual mail you have written.

[peterhoeg]

This change would be great to have.

[david-alvarez-rosa]

@jeremy-compostella, could we have this one checked in? Would be super helpful :)

[jeremy-compostella]

I don't get it. If you are in non posting-style the idea should be to reply inline so why would you want the signature to precede the inline response ?

[david-alvarez-rosa]

I'm going to try to explain why current behavior for me does not work.

When I get an email and I hit r for replying to it, I automatically get into this view

From: David Álvarez Rosa <[email protected]>
To: jeremy-compostella/org-msg <reply+ASOZRK57R7H4VDZ25FFJ34GCQOESHEVBNHHEXG6MUQ@reply.github.com>
Subject: Re: [jeremy-compostella/org-msg] adjust signature position for replies (PR #152)
Date: Wed, 31 May 2023 10:48:57 +0200
In-reply-to: <jeremy-compostella/org-msg/pull/152/[email protected]>
--text follows this line--
#+OPTIONS: html-postamble:nil num:nil ^:{} toc:nil author:nil email:nil tex:dvipng d:nil
#+STARTUP: 
:PROPERTIES:
:reply-to: ("/var/folders/vv/v20qymzd6xs88lycdmdw63ww0000gr/T/mm-291zFT.html")
:attachment: nil
:alternatives: (text html)
:END:


--citation follows this line (read-only)--
On Tue 30 May 2023 at 13:03, Jérémy Compostella wrote:
I don't get it. If you are in non posting-style the idea should be to reply  inline so why would you want the signature to precede the inline response ?


-- 
David Álvarez Rosa
My Fancy Signature...

There are two main issues:

• The signature cannot be change / moved at all (that part is read-only).
• The signature is actually not exported — sending that email will not contain the signature.

The idea will be to have something like

From: David Álvarez Rosa <[email protected]>
To: jeremy-compostella/org-msg <reply+ASOZRK57R7H4VDZ25FFJ34GCQOESHEVBNHHEXG6MUQ@reply.github.com>
Subject: Re: [jeremy-compostella/org-msg] adjust signature position for replies (PR #152)
Date: Wed, 31 May 2023 10:48:57 +0200
In-reply-to: <jeremy-compostella/org-msg/pull/152/[email protected]>
--text follows this line--
#+OPTIONS: html-postamble:nil num:nil ^:{} toc:nil author:nil email:nil tex:dvipng d:nil
#+STARTUP: 
:PROPERTIES:
:reply-to: ("/var/folders/vv/v20qymzd6xs88lycdmdw63ww0000gr/T/mm-291zFT.html")
:attachment: nil
:alternatives: (text html)
:END:


-- 
David Álvarez Rosa
My Fancy Signature...

--citation follows this line (read-only)--
On Tue 30 May 2023 at 13:03, Jérémy Compostella wrote:
I don't get it. If you are in non posting-style the idea should be to reply  inline so why would you want the signature to precede the inline response ?

Does that make sense?

[jeremy-compostella]

In your example you are in top-posting style. If so the code you want to change is not even executed.

[david-alvarez-rosa]

Damn, you are right @jeremy-compostella, now I get it — I was using the standard message-signature-file that does not work integrate well with org-msg (as per #57). Using org-msg-signature instead works like a charm :)

In my particular case, I'm using mu4e with multiple accounts / contexts, and different signatures per account. So, I've added this to my config:

(setq mu4e-compose-signature-auto-include nil)

(defun dalvrosa/set-org-msg-signature (type alternatives)
  (setq org-msg-signature (f-read-text message-signature-file)))
(advice-add 'org-msg-composition-parameters :before 'dalvrosa/set-org-msg-signature)

Sharing in case it helps!