vhdl-style-guide icon indicating copy to clipboard operation
vhdl-style-guide copied to clipboard

Case rules for generic map, port map

Open BasF0 opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. Trying to use vsg's fix option to fix capitalization in a project here, but it seems the right hand side of generic maps and port maps are not checked by any rules. The following two rules only affect the left hand side of the port map. https://vhdl-style-guide.readthedocs.io/en/latest/port_map_rules.html#port-map-002-instantiation-011 https://vhdl-style-guide.readthedocs.io/en/latest/generic_map_rules.html#generic-map-002-instantiation-016

Describe the solution you'd like In my opinion, a consistency rule similar to https://vhdl-style-guide.readthedocs.io/en/latest/signal_rules.html#signal-014 makes sense.

Describe alternatives you've considered Checking for upper/lower case on the right hand side does not suffice; right hand may contain signals or generics with different rules.

BasF0 avatar Apr 21 '21 13:04 BasF0

Hey @BasF0,

I think the right hand side would have to be covered by individual rules like signal-014, or maybe I combine them all into a single case consistency check.

This will give me a chance to improve my parser also.

I took a little break after 3.0.0 was released and I need to get 3.1.0 out. So I will schedule this for 3.2.0.

--Jeremy

jeremiah-c-leary avatar Apr 22 '21 00:04 jeremiah-c-leary

Hey @BasF0,

I was just going through some old issue and was wondering if this is still valid.

--Jeremy

jeremiah-c-leary avatar Feb 12 '22 21:02 jeremiah-c-leary

Hey @BasF0,

Just wanted to ping you about this issue and see if it is still valid.

--Jeremy

jeremiah-c-leary avatar Apr 03 '22 20:04 jeremiah-c-leary

Hey @BasF0 ,

Just wanted to ping you about this issue and see if it is still valid.

--Jeremy

jeremiah-c-leary avatar Oct 05 '22 20:10 jeremiah-c-leary

Hey @BasF0 ,

I am going to defer this issue and will automatically close it December 31st.

If you would like to see this addressed, just let me know.

Regards,

--Jeremy

jeremiah-c-leary avatar Oct 22 '22 13:10 jeremiah-c-leary