Severin Gehwolf
Severin Gehwolf
> > This looks mostly good. I'd prefer if we changed the test to not rely on `InitialHeapSize` as that might get ergonomically set. > > Hmm I see what...
It appears `os::Linux::available_memory()` would need similar treatment, still.
> Hmm, I get uncomfortable if APIs mix layers and try to be smart. > > As in this case, an API that claims to return CG mem limit but...
> > The gist of this patch is code like this: > > ``` > > jlong CgroupV1Subsystem::read_memory_limit_in_bytes() { > > GET_CONTAINER_INFO(julong, _memory->controller(), "/memory.limit_in_bytes", > > "Memory Limit is: "...
> I think the gist of my remark is that I would like the layers to behave consistently. > > I see that `CgroupSubsystem::memory_limit_in_bytes()` is only used in two places,...
@jmtd Please file an RFE ticket for the proposed API cleanup. Thanks!
https://renaissance.dev/ To quote their website: > Renaissance is a modern, open, and diversified benchmark suite for the JVM, aimed at testing JIT compilers, garbage collectors, profilers, analyzers and other tools.
sanity.openjdk on JDK 8 (Hotspot) seems to randomly fail for these tests: ``` java/util/Arrays/TimSortStackSize2.java.TimSortStackSize2 java.lang.OutOfMemoryError: Java heap space at TimSortStackSize2.createArray(TimSortStackSize2.java:164) at TimSortStackSize2.doTest(TimSortStackSize2.java:59) at TimSortStackSize2.main(TimSortStackSize2.java:43) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at...
Upstream OpenJDK no longer tests on Win32, so this might be a test library issue. Either way, I have no way to test or look into this (not a Windows...