ioBroker.yahka icon indicating copy to clipboard operation
ioBroker.yahka copied to clipboard

Published 20 hours ago • verified publisher icon jensweigele

Add AVAHI advertiser as default

Open TA2k opened this issue 2 years ago • 3 comments

Add AVAHI advertiser as default advertiser. Supported since hap-nodejs 0.10 If not AVAHI advertiser is available hap-nodejs fallback to ciao

TA2k avatar Jul 25 '22 07:07 TA2k

LGTM @jensweigele @GermanBluefox please accept and release

Apollon77 avatar Jul 25 '22 08:07 Apollon77

Thanks for submitting that PR! Can you please undo all the formatting changes? That makes it much easier to review the changes.

jensweigele avatar Jul 25 '22 11:07 jensweigele

Here is the last functional commit without formatting https://github.com/jensweigele/ioBroker.yahka/pull/350/commits/ad8e3b6a0d64db22b00be9a4fdaca822ee7933ec

or all commits after formatting https://github.com/jensweigele/ioBroker.yahka/pull/350/files/b0ebb36e25555bf5882cd2f4b9e65c8a1fe183b8..ad8e3b6a0d64db22b00be9a4fdaca822ee7933ec

TA2k avatar Jul 25 '22 12:07 TA2k

@jensweigele can you have a look again on the PR

TA2k avatar Aug 19 '22 08:08 TA2k

@GermanBluefox Can you please have a look and release a new version

TA2k avatar Sep 27 '22 08:09 TA2k

I reverted the push since it looks like it broke the software (see #359)

jensweigele avatar Oct 16 '22 20:10 jensweigele

Just saw that someone also published that broken version to NPM - I'm going to release a 0.16 to revert the changes...

jensweigele avatar Oct 16 '22 20:10 jensweigele