Jens Tröger
Jens Tröger
> #111 is merged now. Thanks @icemac, rebased my PR.
Agreed, I’ve deleted the [tm](https://transaction.readthedocs.io/en/latest/api.html#transaction.interfaces.ITransactionManager) reference from two [IDataManager](https://transaction.readthedocs.io/en/latest/api.html#transaction.interfaces.IDataManager) implementations. Other than a code-smell, I can’t think of a scenario where a data manager would need a back-reference to the...
@mgedmin, looking at the [`abort()` code](https://github.com/zopefoundation/transaction/blob/master/transaction/_transaction.py#L499-L531) I don’t see the function being an alias, nor does it begin a new transaction. But even if that were the case, the `"Active"`...
> I think this issue is about the state of the transaction object itself which is not shared across transactions handled by the manager. @mmerickel, correct. I ran into a...
@jimfulton, here you go: pull request https://github.com/zopefoundation/transaction/pull/64 😉
Thanks @akx, happy to create a PR if you don’t mind a little guidance: - I think a `list[str]` would suffice, which then contains the two-letter country codes? - Should...
> 1. Sure, just a frozenset of ISO 3166-2s should be fine to begin with, I think? (A list is needlessly ordered.) …and performs worse when searched. You just beat...
I think using `ldml/identity/territory/@type` (from files in `main/*.xml`) doesn’t work. For reference, I downloaded [ISO_3166-1_alpha-2.html](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2) from Wikipedia and extracted the set of “Officially assigned” country codes ```xpath //table[@class="wikitable"][2]//td[contains(@style, "#9EFF9E") or...
> Scraping the Wikipedia page during the import process sounds like a bad idea, and dealing with ISO to license the country codes for use in Babel also sounds problematic....