laravel-rollbar icon indicating copy to clipboard operation
laravel-rollbar copied to clipboard

Published 20 hours ago • verified publisher icon jenssegers

Adds Lumen 5.x support

Open GiamPy5 opened this issue 8 years ago • 22 comments

Adds Lumen 5.x support by using Monolog\RollbarHandler.

GiamPy5 avatar May 23 '16 11:05 GiamPy5

StyleCI analysis has been fixed, it shows as failed because I have used a soft reset to squash the commits. @jenssegers

GiamPy5 avatar May 23 '16 11:05 GiamPy5

Wouldn't it be better to refactor the original service provider so that the Lumen service provider can extend it and only override Lumen specific stuff?

This way there is less code duplication.

jenssegers avatar May 24 '16 09:05 jenssegers

@jenssegers That's actually a good idea, I'll work on that instead.

GiamPy5 avatar May 25 '16 08:05 GiamPy5

Any update on this PR or your code changes @GiampaoloFalqui? Thanks.

earnaway avatar Jun 17 '16 12:06 earnaway

since it's been a while,i created my PR #60 for this as @jenssegers asked.

nickfan avatar Jun 25 '16 06:06 nickfan

Thanks for the update @nickfan - I do notice that all the checks failed on that PR in StyleCI and Travis CI - @jenssegers might not be able to merge that in.

earnaway avatar Jun 27 '16 07:06 earnaway

@earnaway i have rewrite the code #60 for the check , it passed StyleCI and travis-ci, but coverage/coveralls Coverage decreased (-9.9%) to 65.116% ,is that ok for merge?

nickfan avatar Jun 27 '16 14:06 nickfan

I guess we'll have to wait for @jenssegers to look over it and hopefully merge that into master.

earnaway avatar Jun 28 '16 14:06 earnaway

Any updates on this? It'd be really nice to have Lumen support as there aren't any other packages that do this ATM.

bkuhl avatar Jul 31 '16 21:07 bkuhl

I am very sorry about the huge await, I have improved the Pull Request by using Inheritance. @jenssegers feel free to give a look.

GiamPy5 avatar Aug 01 '16 09:08 GiamPy5

Looks like we're unable to merge due to unresolved conflicts, can you look at those?

bkuhl avatar Aug 01 '16 12:08 bkuhl

@bkuhl Done!

GiamPy5 avatar Aug 01 '16 12:08 GiamPy5

Any news?

GiamPy5 avatar Aug 25 '16 16:08 GiamPy5

The build is still failing

bkuhl avatar Sep 20 '16 17:09 bkuhl

Has anyone taken a look at this in awhile?

jasonroman avatar Mar 12 '17 01:03 jasonroman

Build fixed and code updated with the latest master changes!

GiamPy5 avatar May 15 '17 16:05 GiamPy5

Lumen support is desperately needed. Looking at the committed files I don't see a completed test case for src/RollbarLumenServiceProvider.php. Thats why coveralls coverage is decreasing/failing

RudyJessop avatar May 31 '17 20:05 RudyJessop

There isn't a way to test the LumenServiceProvider, it only exists for Laravel unfortunately.

GiamPy5 avatar May 31 '17 20:05 GiamPy5

@jenssegers Is there any chance this PR is merged even if RollbarLumenServiceProvider is not covered by tests? If not: Would you accept a dirty work-a-round to get it tested or is this one blocked by orchestra/testbench not supporting lumen? Please note that crynobone said that adding lumen support to orchestra/testbench might be possible for lumen >= 5.2 but as far as I know nobody is working on it yet.

jelhan avatar Jun 27 '17 08:06 jelhan

FWIW this morning I followed this tutorial to create a custom service provider in order to use this package with a Lumen 5.2 project, and it worked like a charm:

https://recursionrecursion.co.uk/post/integrating-rollbar-with-lumen

wjgilmore avatar Aug 16 '17 15:08 wjgilmore

Hi all, any news for this? I know we can do the custom service provider, but it is best to have it on the package.

khoivm avatar May 23 '18 03:05 khoivm

@wjgilmore I tried that tutorial for Lumen 5.7 and it uses deprecated methods and of course fails. If James Elliot would update it for Lumen 5.7 it could make lives easier but for now, it doesn't work for the current version of Lumen

chukkynze avatar Nov 21 '18 17:11 chukkynze