laravel-mongodb-core
laravel-mongodb-core copied to clipboard
jenssegers
Looking for reviewers
Hi there!
The popular laravel-mongodb package is due for a revamp! I'm not going to tackle the entire project all at once, because of the Eloquent functionality it is quite big.
@ollieread proposed to split off the core functionality of laravel-mongodb without Eloquent support into a separate repository. I think this is a great idea and will start off with that as a first step. Once this repository is stable and feature complete, I will make an effort removing all core features from laravel-mongodb with this as a dependant package.
Currently I'm looking for people with some spare time that can review the code as I go. So if you're up for it, leave a comment below and watch the repository for changes! ❤️
Hi @jenssegers
I'm more than happy to help review, as well as contribute if there's anything specific needed. Apologies for the delay, I've recently moved house.
@jenssegers I am happy to help with code review and other contribution where needed. Cheers!
I've already pushed some code to the repository and updated the readme: https://github.com/jenssegers/laravel-mongodb-core
I think this is already much cleaner code base than previously 💪
Thanks for your time. Currently there are many pull requests in laravel-mongodb. I think the response time needs to be improved. Is there going to be a plan there as well? I would love to help, though I am new in Mongodb.
@halaei I hope by splitting up the packages it will be a bit easier to separate bugs in the core, or additional features that are not yet implemented for Eloquent.
Once this core package is feature proof. It will replace the core code and hopefully provide a more stable package.
@jenssegers I'm going through the code, making some adjustments and tidying up, as well as trying to bring a bit more in line with how the core works. You can see this at: https://github.com/ollieread/laravel-mongodb-core
Since this package requires PHP 7.1 by proxy (through illuminate/database 5.6) am I okay to use strict return types where necessary? I wasn't sure if there was a reason you were avoiding it.
@jenssegers Can I also suggest that you leave some comments for some of the compile methods in the query grammar, for example, whereSub, whereSubIn and whereSubNotIn. I'm not sure what you intend for those methods.
I was interested in helping out on the laravel-MongoDB package. I would gladly help with some code review on here to speed up the process of a more robust MongoDB package for laravel.
@jenssegers, i am ready review code in main repository in laravel-mongodb. Our team uses this repository for work with mongo, because we are ready to contribute in repository and help with code review.
Hello @jenssegers , despite the delay, I will be very happy to contribute in my available time.
