electron-release icon indicating copy to clipboard operation
electron-release copied to clipboard

Published 20 hours ago • verified publisher icon jenslind

Improve compress

Open maxcnunes opened this issue 9 years ago • 7 comments

Remove exec command and add support to compress files from any platform. Since I guess ditto is not available in all platforms.

Also ditto command was not working with paths including withe space.

maxcnunes avatar Nov 29 '15 02:11 maxcnunes

Thanks for the PR! Do you know if archiver will work with signed apps? https://github.com/jenslind/electron-release/issues/1#issuecomment-144082722

jenslind avatar Nov 29 '15 13:11 jenslind

Humm I didn't know there was this concern. By the description of the problem in stack overflow I guess it may will not work. Sorry I dond't have a Apples' certificate to test it (too expensive).

maxcnunes avatar Nov 29 '15 14:11 maxcnunes

No need for a certificate from Apple. You should be able to use a self signed one too.

jenslind avatar Nov 29 '15 17:11 jenslind

Humm. I didn't know that too :smile:
Ok I will try it later in the week.

maxcnunes avatar Nov 29 '15 17:11 maxcnunes

Any updates on this? :)

stilliard avatar Jan 26 '16 11:01 stilliard

Sorry. I didn't test it and and since I'm not using this lib anymore I will not have time to work on this. :cry: In case someone is interested in test it, please do. Otherwise I guess this pull request could be rejected.

maxcnunes avatar Jan 26 '16 23:01 maxcnunes

@jenslind I've tested out using archiver on a signed app, and it seems to be working.

When I run codesign -dvvv <My App>.app on a signed app after unzipping with the Archive Utility, it is still signed.

Just an FYI :)

natecavanaugh avatar May 25 '16 14:05 natecavanaugh