Unicode problems in renderChains

[andreastt]

The renderChains routine that displays the comments attached to a review (/r/N) has problems displaying unicode characters.

See the attached screenshot where the character ’ is replaced by �:

[andreastt]

I guess this is a problem with lack of unicode strings and string slicing in src/reviewing/comment/__init__.py:159, or potentially how strings are decoded when they come out of the database.

[jensl]

Critic uses UTF-8 encoded byte strings throughout, including to/from the database, so the string slicing you point to is certainly problematic, and very likely to have caused the issue in the screenshot given that the error is at the end of the string.