critic icon indicating copy to clipboard operation
critic copied to clipboard

Blame functionality is not quite like real blame

Open rchl opened this issue 11 years ago • 4 comments

blame (b) in the changeset view works as expected for lines that were modified in this commit but for all other lines it will just point to the parent commit, instead of like real git blame, pointing to the commit that modified the line.

rchl avatar May 25 '13 21:05 rchl

This is what it is designed to do, yes. In particular, in a "squashed diff" it is meant to tell you which of the contributing commits contributed what change. This means of course that it is rather pointless in its current form on a single-commit diff, and should really be disabled there.

jensl avatar May 26 '13 07:05 jensl

Or just show it for the lines that have blame markers, whether in single commit view or not. I think it worked like that some time before...

rchl avatar May 26 '13 21:05 rchl

You mean disable the tooltips that blames the parent commit? Yeah, that'd make sense, I guess.

jensl avatar May 26 '13 21:05 jensl

Although I'm pretty sure it never worked that way.

jensl avatar May 26 '13 21:05 jensl