Jens Schulze

Results 76 comments of Jens Schulze

It could. But visibility is quite low

This is an issue of the ObjectMapper used by springdoc. The SDK adds the ApiModule to the ObjectMapper used for De-/Serialization. This includes a ReviewMixin class which helps correctly deserializing...

I'm actually unsure if it should be solved inside the SDK. The Config object already tries to deal with a lot of different combinations for the scope string. See https://github.com/commercetools/commercetools-php-sdk/blob/a1f12b67811808bf73b7ec9d405fdaabb50670e3/tests/unit/ConfigTest.php#L167-L224...

The Me-Endpoints are supported. See https://github.com/commercetools/commercetools-php-sdk/tree/master/src/Core/Request/Me and https://github.com/commercetools/commercetools-php-sdk/tree/master/tests/integration/Me But lately I didn't invest more time in adding newly introduced features. I would need to redesign how the client authentication against...

As a product can have more than one category, which category should be used for a product url? /:languageTag/:categorySlug/:productSlug-:sku.html Also SKUs may contain a "-". Maybe not for our sunrise...

Routes i'm declared so far: /:locale/ - catalog.controller:home /:locale/search/ - catalog.controller:search /:locale/cart/add - cart.controller:add /:locale/cart/delete - cart.controller:deleteLineItem /:locale/cart/change - cart.controller:changeLineItem /:locale/cart - cart.controller:index /:locale/category - catalog.controller:search /:locale/:slug.html - catalog.controller:detail /:locale/:slug/:sku.html...

Oh yeah. I would have to check this again. At the point were I wrote this not the whole tool chain could work correctly with this one.

It's a good question if it's a breaking change as the old client package was written in NodeJS. The v2 version is now written in Typescript and includes all necessary...

I totally understand your point. Just wanted to say the change itself is not necessary as v1 & v2 client are valid to be used using the SDK. We advise...

The QueryAll is a helper class to conveniently get all elements of a query without the limitations from using offset & limit query parameters. As a matter of fact it...