node-ical
node-ical copied to clipboard
jens-maus
Corrected timezone handling for recurring events
... and fixed some apparent bugs along the way.
This includes new tests. All existing tests succeed.
Thank you for your review and detailed feedback!
In addition, please take note that some unit test is failing with you changes incorporated. Thus, please check and correct that as well.
Indeed, one of the tests is failing, which wasn't the case, when I committed this (before Oct 30). This could be a DST problem. I will look into it.
Just wanted to know is this PR going to get merge soon ? I am stuck with this problem too. Thank you.
This feels like a critical bug... not sure why this hasn't been figured out yet. I've put up an alternative solution in #329, which hopefully will be easier to review?
