hacktoberfest-checker icon indicating copy to clipboard operation
hacktoberfest-checker copied to clipboard

Published 20 hours ago • verified publisher icon jenkoian

FAQ page footer's FAQ button changed to Home button

Open developer-nobita opened this issue 3 years ago • 4 comments

Fixes #601 Changed footer component to treat FAQ page and other pages differently.

Screenshots:

Screenshot (33)

Screenshot (34)

developer-nobita avatar Oct 22 '21 16:10 developer-nobita

This is a nice approach. Only issue is that location.pathname is case sensitive.

aarai avatar Oct 23 '21 21:10 aarai

I think converting location.pathname to lowercase will solve this issue. Is it correct?

developer-nobita avatar Oct 24 '21 07:10 developer-nobita

Correct.

Sent from a phone

On Oct 24, 2021, at 3:00 AM, Ronak Upadhyay @.***> wrote:

 I think converting location.pathname to lowercase will solve this issue. Is it correct?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

aarai avatar Oct 24 '21 11:10 aarai

Hey @developer-nobita sorry I've had some time off lately so haven't had chance to review this, I'll mark it as accepted though as it looks good, will hopefully be able to review over either today or tomorrow.

jenkoian avatar Nov 01 '21 10:11 jenkoian