[JENKINS-46124] - support map with EnvStep
Fixes JENKINS-46124
Revival of https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/105 by @jetersen.
I forked jetersen:fix/JENKINS-46124 and merged the latest from jenkinsci:master.
I also completed the outstanding request to update the help text for the withEnv step and its overrides argument to mention the new map syntax.
Testing done
See mapArguments() and mapArgumentsAsMap() tests added in the original PR.
Submitter checklist
- [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [ x Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests that demonstrate the feature works or the issue is fixed
@jetersen @dwnusbaum I hope this has been the right approach, but I would really like to see the changes from https://github.com/jenkinsci/workflow-basic-steps-plugin/pull/105 merged and released 🙏.
@jglick @dwnusbaum @basil is anyone able to review this change please?
Well, I can put it on my backlog, but my backlog is pretty long.