Uniformed fixed issues presentation.

[abramobagnara]

Previous fixed issues presentation is less featured than presentation of other issues with no added benefits.

[codecov[bot]]

Codecov Report

Merging #736 (dd229ec) into master (13c4980) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #736   +/-   ##
=========================================
  Coverage     79.72%   79.73%           
  Complexity     1529     1529           
=========================================
  Files           243      243           
  Lines          5589     5590    +1     
  Branches        409      409           
=========================================
+ Hits           4456     4457    +1     
  Misses          970      970           
  Partials        163      163           

Impacted Files	Coverage Δ	Complexity Δ
...ins/plugins/analysis/core/model/DetailFactory.java	94.44% <100.00%> (+0.07%)	23.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13c4980...e937dd8. Read the comment docs.

[uhafner]

Well, the added benefit is that it is a special and reduced view that renders the results in a simple way. I do not see a benefit to show the full capacity view for fixed warnings as well. This view will never be used to navigate to issues.

[abramobagnara]

Well, the added benefit is that it is a special and reduced view that renders the results in a simple way. I do not see a benefit to show the full capacity view for fixed warnings as well. This view will never be used to navigate to issues.

I'm very surprised you say that: with the modified plugin we navigate the fixed issues all the time (to see what has been fixed).

[uhafner]

Ok, seems you are using the plugin in a different way. So let's be more precise: what elements of the issues detail view are you using that is not part of the reduced view? How many fixed warnings do you typically have?

From https://github.com/jenkinsci/analysis-model/pull/553 it looks like you are dealing with a lot of issues.

[abramobagnara]

We have up to thousands of fixed issues in special cases.

The reduced view does not permit selection and does not show the issue details (compare e.g. https://ci.eclipse.org/skills/job/skills.build.nightly/111/analysis/new/ with https://ci.eclipse.org/skills/job/skills.build.nightly/111/analysis/fixed/ ).

If you think it is useful I can send to you privately the credentials to see the special uses we do of issue details to link the jenkins issue to our static analysis reports browser.

[uhafner]

I see.

In this case it would make sense to completely remove the view (FixedWarningsDetail and jelly files).

[abramobagnara]

I've removed it as you proposed.

[uhafner]

Ok, thanks. I installed it on my machine and two things are now not ideal:

• the link to the fixed source code is on the new file (it pointed to the file with the actual warning)
• if there are no fixed warnings then the details look strange.

[abramobagnara]

For the first point I agree it is suboptimal and if feasible it would be better to point to issue location in reference build. For the second point I don't understand what you mean.

[uhafner]

[abramobagnara]

This looks strange also for the New issues (only a litte less)...

What would you propose?