warnings-ng-plugin icon indicating copy to clipboard operation
warnings-ng-plugin copied to clipboard

Adding Aquasec icon.

Open Mulgish opened this issue 2 years ago • 3 comments

Adding Aquasec icon following https://github.com/jenkinsci/analysis-model/pull/820.

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did
  • [ ] Link to relevant issues in GitHub or Jira
  • [x] Link to relevant pull requests, esp. upstream and downstream changes
  • [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Mulgish avatar Jul 30 '22 16:07 Mulgish

Codecov Report

Merging #1323 (6cbd22f) into master (ae60678) will increase coverage by 0.09%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1323      +/-   ##
============================================
+ Coverage     79.59%   79.68%   +0.09%     
- Complexity     1444     1446       +2     
============================================
  Files           249      249              
  Lines          5532     5533       +1     
  Branches        426      426              
============================================
+ Hits           4403     4409       +6     
+ Misses          978      974       -4     
+ Partials        151      150       -1     
Impacted Files Coverage Δ
...jenkins/plugins/analysis/warnings/AquaScanner.java 85.71% <100.00%> (+2.38%) :arrow_up:
...ns/plugins/analysis/core/model/AnalysisResult.java 89.57% <0.00%> (+3.06%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Jul 30 '22 17:07 codecov[bot]

I am curious if it would be better if we generated icons ourselves based on tool abbreviations? That way it makes it easier to distinguish them on the UI rather than seeing the default icon.

Yes, this is an interesting idea. I'm planning to add a toggle to switch all icons to black and white ones that match better with Jenkins new design (and that are theme aware). Since most tools do not offer black and white iccons I need to replace them with something new (or with the default triangle warning icon).

uhafner avatar Jul 31 '22 20:07 uhafner

I started a PR that introduces some symbols now, see https://github.com/jenkinsci/warnings-ng-plugin/pull/1356.

uhafner avatar Sep 20 '22 20:09 uhafner