versionnumber-plugin icon indicating copy to clipboard operation
versionnumber-plugin copied to clipboard

introduce DAYS_SINCE_PROJECT_START

Open dss539 opened this issue 10 years ago • 3 comments
trafficstars

credit to @felegy for the changes

dss539 avatar Nov 09 '15 20:11 dss539

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

jenkinsadmin avatar Nov 10 '15 01:11 jenkinsadmin

Hello Derrick, sorry for the late response. I somehow missed the github-notification and your e-mail as-well.

Your changes seem to work and are a useful extension to the plugin. However, in order to not being overlooked, the new feature should have some kind of documentation/help. At least it should be mentioned in the help that gets displayed when clicking the little ?-icon next to the appropriate option. Some tests are always good, too.

So, before accepting your pull-request, I recommend you add the appropriate documentation and a small test-case. The files you need to edit for this are already existent and you should easily determine how to add the documentation and test.

Additionally, I would like you to squash all your changes into a single commit. For information about how to do this you can look here.

Thanks, Deniz

DenizThatMenace avatar Feb 18 '16 11:02 DenizThatMenace

Hi Deniz,

I'll try to address your concerns after I set up an java dev environment. Thanks for responding, I'll put this on my TODO list.

Best Regards, Derrick

dss539 avatar Feb 18 '16 18:02 dss539

Closing as unlikely to ever be merged.

MarkEWaite avatar Feb 16 '25 00:02 MarkEWaite