subversion-plugin [JENKINS-6415] fail on external error

I believe an error while handling externals should fail the build. see JENKINS-6415

Sep 06 '13 14:09 domruf

Jenkins » subversion-plugin #188 UNSTABLE Looks like there's a problem with this pull request (what's this?)

Sep 06 '13 14:09 buildhive

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Sep 06 '13 18:09 jenkinsadmin

a svn test repository seems to be down therefore a test fails

Sep 09 '13 14:09 domruf

Thanks for the PR. Sorry that this was left without attention for so long.

Can you created a regression test case for the change? https://wiki.jenkins-ci.org/display/JENKINS/Unit+Test

Oct 31 '13 15:10 kutzi

The PR stills actual. It would worth to merge it

Jul 05 '15 09:07 oleg-nenashev

@oleg-nenashev I'll review the bug and the solution. I've assigned myself this ticket JENKINS-6415

Jul 19 '15 21:07 recena

Hi, any progress on that ?

Feb 22 '16 12:02 mastier

@mastier Soon.

Feb 22 '16 12:02 recena

your last response was 7 months ago :-) I hope "soon", it does not mean next half-year. What stops you from merging it (it merges cleanly) ? You prefer implementing it as an optional "tick" ? "Fail on external builds".

2016-02-22 13:27 GMT+01:00 Manuel Recena [email protected]:

@mastier https://github.com/mastier Soon.

— Reply to this email directly or view it on GitHub https://github.com/jenkinsci/subversion-plugin/pull/50#issuecomment-187151908 .

Kind regards, Bartosz Woronicz

Feb 22 '16 12:02 mastier

@mastier Maybe because I was working on 7 revisions of this plugin :dizzy_face:

Feb 22 '16 12:02 recena

Ok, I thought it was quite important fix and easy to introduce... Do not feel like I am pushing, because I am not.

Feb 22 '16 14:02 mastier

I see that doesn't not compile anymore, 'cause there were changes in SVNkit api. Would you advice me how to fix just for myself ?

What replaces getExternalInfo() in the current API ? http://svnkit.com/javadoc/

i.e. here: String msg = String.format("Error handling external %s to url %s", event.getExternalInfo().getPath(), event.getExternalInfo().getUnresolvedUrl());

SVNEvent object event does not have method like getExternalInfo()

I asked the same also on the SVNkit mailing list. http://subversion.1072662.n5.nabble.com/getExternalInfo-in-SVNEvent-in-current-API-td196210.html

Mar 02 '16 08:03 mastier

Hi, @recena We faced same issue in our project. I was glad to find a fix here, thank you for that. Will try to compile plugin version with the fix myself, but... It would be great to have it in latest, wouldn't it?

@mastier Any update on the issue?