subversion-plugin icon indicating copy to clipboard operation
subversion-plugin copied to clipboard

Removed 1 unnecessary stubbings in SimpleSVNDirEntryHandlerTest.java

Open ARUS2023 opened this issue 9 months ago • 0 comments

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

In our analysis of the project, we observed that

  1. 1 stubbing which stubbed getDatein SimpleSVNDirEntryHandlerTest.getEntry which is invoked inSimpleSVNDirEntryHandlerTest.addEntries but never executed by 3 tests: SimpleSVNDirEntryHandlerTest.testSortByName, SimpleSVNDirEntryHandlerTest.testReverseSortByName, SimpleSVNDirEntryHandlerTest.testFilter.

Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).

We propose below a solution to remove the unnecessary stubbings.

ARUS2023 avatar Oct 06 '23 01:10 ARUS2023