[JENKINS-5347] Added use commit times on files

[ekesseler]

http://issues.jenkins-ci.org/browse/JENKINS-5347

Applied your change requests from: https://github.com/jenkinsci/subversion-plugin/pull/64/files

Please approve and add this to the next version or give me feedback.

Thank you

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[ekesseler]

Seems like the checkout failed (timeout) during the test

[ekesseler]

The test failing (timeout) had nothing to do with the commit.

[christ66]

@dvlemplek Can you re-base your pull request. The tests that are failing were fixed.

[ekesseler]

Other tests failing, had nothing to do with the commit.

[oleg-nenashev]

The most of the pull requests looks good to me. If the backward compatibility issue gets fixed, I would vote for merging it

[ekesseler]

You would have to tell me the JIRA ISSUE, since I don't have access to it.

[oleg-nenashev]

http://issues.jenkins-ci.org/browse/JENKINS-5347 The entire JENKINS project in JIRA is public, hence you should have an access

[tomap]

Hi,

I have the same need. Would be glad to see this pull request merged.

Thank you

[oleg-nenashev]

@dvlemplek :+1: for the PR when a minor comment gets fixed. BTW, the commits should be squashed into a single one

[recena]

@dvlemplek Do you plan to review @oleg-nenashev 's comments?

[ekesseler]

@oleg-nenashev I thought I already did: https://github.com/dvlemplek/subversion-plugin/commit/c13f6f56bfa50055073f2c6b993876956a39fbb8

[ekesseler]

Please let me know if something is missing, I don't see it at the moment.

[recena]

@dvlemplek I'd like to make a smoke test before to merge this. I'll back here this night.

[recena]

@dvlemplek If you are working on JENKINS-5347, please accept the issue and update its status (in progress).

[ekesseler]

Should be all done now?

[oleg-nenashev]

:+1:

[recena]

@dvlemplek As @oleg-nenashev said, the commits should be squashed into a single one

[recena]

@dvlemplek We plan to cut a release (revision) at the end of this week. I hope to include your PR.

[ekesseler]

How is the status on this? The build failed because of unrelated timeouts, can you trigger it again and include the pull request?

[recena]

@dvlemplek I'll try to review it as soon as possible.

[ekesseler]

Merged upstream and fixed your comments.

[recena]

@dvlemplek Great!

[christ66]

LGTM

[unitychrism]

This is working as expected with a built version of the plugin on my end, thanks for the re-focus :-)

[unitychrism]

Any hope of a merge anytime soon?

[kennetn]

Any news on this ?

[DaveNoth]

You do fantastic work with this plugin so I understand if we can get it in soon. If there is anyway, please consider it. We would love this fix.

[jglick]

Not accepting new features at this time unless obviously self-contained. (Also would need to use @DataBoundSetter.)

[oleg-nenashev]

merge conflict